Open
Conversation
- Use explicit label values - Track download at the copy level Unified label values for object store actions.
rdettai
changed the title
rdettai
force-pushed
the
update-metrics-doc
branch
from
e97ef66 to
a7f12de
Compare
rdettai
commented
Jul 16, 2025
Comment on lines
-24
to
-25
| pub replicated_num_bytes_total: IntCounter, | ||
| pub replicated_num_docs_total: IntCounter, |
Collaborator
Author
There was a problem hiding this comment.
moved this to be part of of ingest_v2 metrics
|
|
||
| pub replicated_num_bytes_total: IntCounter, | ||
| pub replicated_num_docs_total: IntCounter, | ||
| #[allow(dead_code)] // this really shouldn't be dead, it needs to be used somewhere |
Collaborator
Author
There was a problem hiding this comment.
this has been dead for a year
Comment on lines
-35
to
-36
| pub object_storage_get_slice_in_flight_count: IntGauge, | ||
| pub object_storage_get_slice_in_flight_num_bytes: IntGauge, |
Collaborator
Author
There was a problem hiding this comment.
- I created this metric to make sure that this wasn't the reason for OOMs on search and I confirmed it's not the case
- I think it makes sense to keep tracking the memory usage, but move it to quickwit_memory_in_flight where it is more discoverable and actionable
rdettai-sk
force-pushed
the
revamp-storage-metrics
branch
6 times, most recently
from
0da6565 to
0a4a5f9
Compare
rdettai-sk
force-pushed
the
revamp-storage-metrics
branch
from
0a4a5f9 to
69c1c7b
Compare
rdettai-sk
force-pushed
the
revamp-storage-metrics
branch
2 times, most recently
from
24a7d1f to
63ae79d
Compare
rdettai-sk
force-pushed
the
revamp-storage-metrics
branch
from
63ae79d to
07a973a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Generate an updated metrics docs using copilot. Most metrics have been checked manually and comments have been added. Some of them where not verified, like OTLP and Jaeger metrics. In any case, it cannot be worse that the current doc that is completely outdated.
Also removed the
get_slice_in_flight_*metrics to have these memory allocations measured as part ofquickwit_memory_in_flight. This makes it more discoverable and usable.How was this PR tested?
Tested some of the metrics on a running instance.